Add delisted flag to people #2176
Merged
+47
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symroe
force-pushed
the
delist-people
branch
from
55828dc to
64783c8
Compare
symroe
force-pushed
the
delist-people
branch
2 times, most recently
from
c8fc69e to
8eb1b5e
Compare
|
Test failing due to a fix that's in #2174. I'll rebase after that's in |
symroe
force-pushed
the
delist-people
branch
from
8eb1b5e to
0d2c17f
Compare
|
After marking a person as delisted, they still appear on the site. Is that expected? Other than seeing the option to delist in the admin panel, is there any way to test this works? |
|
You can look at the API, as per: https://github.com/DemocracyClub/yournextrepresentative/pull/2176/files#diff-7ec8f1ac24e0fd870ae508117bfc843ab82e782239894bb1ffbb63e583e79f14R117-R120 There's no other change in YNR though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow admins to mark a person as delisted.